Post Schedule Panel: Remove text overflow ellipsis #56319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
|
Size Change: +53 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Alignment looks a little off, and the button is smaller than the others (27px vs 36px). 
|
|
I think it should be fixed now. |
mcsf
approved these changes
Nov 20, 2023
Comment on lines
+7
to
+8
| justify-content: flex-start !important; | ||
| align-items: flex-start !important; |
There was a problem hiding this comment.
Maybe explain why this needs to be conditional now?
There was a problem hiding this comment.
Good remark, the conditional style is actually not needed now.
|
I pushed a commit that updates these buttons to use the new 40px default sizing. Appreciate this touches more files so feel free to revert if that's beyond scope. I felt it was a neater approach than adding custom overrides. The multi-line button still looks a bit funky, but that's a separate issue. |
|
@jameskoster There's actually a lot of buttons that needs updating. There's buttons (and not controls) that are visible only in the post editor, in some very specific conditions... So I'm a bit hesitant to keep this change. |
See how for instance the spacing is a bit off between the toggles and the big buttons. |
youknowriad
force-pushed
the
update/post-schedule-toggle
branch
from
683157d to
5a5dc78
Compare
|
Ok I've reverted the button size changes @jameskoster I think these are valuable changes but should probably be explored separately of the current issue in a wholistic way. |
|
Oh I just reverted too 🙈 |
jameskoster
reviewed
Nov 20, 2023
| white-space: nowrap; | ||
| white-space: unset; | ||
| height: auto; | ||
| padding: 10px 12px; |
There was a problem hiding this comment.
This padding is creating a 35px button for me. Maybe use min-height: $button-size instead?
There was a problem hiding this comment.
min height doesn't work properly for multi-line buttons. We can have both though.
There was a problem hiding this comment.
Ok so I added a line height using pixels and a comment explaining why.
There was a problem hiding this comment.
I see what you mean. Seems fine now:
Should we use the $grid-unit-* vars?
There was a problem hiding this comment.
Should we use the $grid-unit-* vars?
We can't, button block is not really using them and 10px is not really there. Potentially we can use calculations.
There was a problem hiding this comment.
Trying calculations.
youknowriad
force-pushed
the
update/post-schedule-toggle
branch
from
5cfbcca to
c94e615
Compare
| height: auto; | ||
|
|
||
| // The line height + the padding should be the same as the button size. | ||
| padding: ( ( $button-size - $grid-unit-20 ) / 2 ) 12px; |
There was a problem hiding this comment.
Looks like this introduced a deprecation warning when building Gutenberg. Tiny follow-up PR over in #56412 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #56196
Closes #56262
What?
The PostSchedule unification PR kept the format of the post editor (full date visible) but kept the style of the site editor (text overflow cut using an ellipsis). This PR restores the styling of the post editor which used to render the full date.
Testing Instructions
1- Schedule a post in the future
2- Notice that the date is shown fully.